fixed incorrect python wildcard example#37959
fixed incorrect python wildcard example#37959Subramanya-Veeregowda wants to merge 3 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam programming guide by incorporating a practical Python example for wildcard field selection. This addition clarifies how developers can efficiently select nested fields within data structures, thereby making the documentation more comprehensive and ensuring better consistency across the various SDKs supported by Beam. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Assigning reviewers: R: @damccorm for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| << highlight py >> | ||
| input_pc = ... | ||
| output_pc = input_pc | beam.Select("shippingAddress.*") | ||
| << /highlight >> |
There was a problem hiding this comment.
The snippet immediately above this says that "Support for wildcards hasn't been developed for the Python SDK yet." - have you tried this snippet out?
There was a problem hiding this comment.
Good catch, thanks for pointing this out.
You're right — since Python SDK doesn't support wildcards yet, this example may be incorrect. I’ll verify it locally and update or remove the snippet accordingly.
There was a problem hiding this comment.
Lets just close this PR since adding this example was the point of the PR.
Please manually verify changes before pushing them (don't just feed them into an AI tool)
Added a python example demonstrating wildcards selection using dot notation in the programming guide.
This improves documentation consistency across SDKs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.